Merged
Conversation
5c940a2 to
00c1a94
Compare
|
Hi @magnusuMET, |
|
Hi, So from my side it would be great to merge this! |
|
Hi @magnusuMET , any updates on this PR? It would be great to have this functionality available in master |
|
@mulimoen if this is not ready for merging to master, perhaps you could rebase on master instead, to incorporate the latest changes (such as ndarray v0.17 support) |
921d6c7 to
5c570f3
Compare
|
awesome, thanks for merging! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A first stab at Single Writing Multiple Readers.
Seems there might be a bug for shape checking which should be fixed by only reading shape once per read
Fixes #78
@philbucher You may play around with this prototype and see if it fits your needs